Support Webpack-based frameworks, require Storybook 10.1 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 031169f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
JReinhold
commented
Oct 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the addon from Vite-specific middleware to the new experimental_devServer preset property, enabling support for Webpack-based frameworks (Next.js, react-webpack5) while maintaining Vite compatibility. It requires Storybook 10.1+ (currently available as a canary).
Key Changes
- Replaces Vite plugin workaround with
experimental_devServerpreset hook - Updates minimum Storybook version requirement from 9.0 to 10.1 (canary)
- Adds Webpack-based framework support (Next.js, react-webpack5)
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds Storybook canary versions to catalog, removes comment sections |
packages/addon-mcp/src/preset.ts |
Replaces viteFinal Vite plugin with experimental_devServer preset hook |
packages/addon-mcp/package.json |
Updates peer dependency to use catalog version instead of semver range |
packages/addon-mcp/README.md |
Updates documentation to reflect Webpack support and new version requirement |
apps/internal-storybook/package.json |
Updates dev dependencies to use catalog versions |
apps/internal-storybook/.storybook/main.ts |
Corrects story directory path |
.changeset/dark-eagles-argue.md |
Documents breaking change and version requirement |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to using the new
experimental_devServerpreset property introduced in storybookjs/storybook#32816 . It also means that it now requires Storybook versions that has that property, which currently are only canaries.I manually tested that this worked both with Vite and Webpack, by modifying the Storybook in this reop.