Hide controls if they are disabled using the built-in includeConditionalArg functoin
#714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onalArg` function
daviegourevitch
commented
Apr 16, 2025
|
Hey this looks good, thanks for the pr 🙏 . Unfortunately I'm a bit unavailable for about a week so I'm not able to fully test but I really appreciate it. I will get this tested and merged as soon as I can. |
|
Perfect, thanks so much! |
|
made a slight adjustment to get the value from a function call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #711
What I did
I call the pre-existing function
includeConditionalArgfor each arg in on-device-controls and only render them if their condition is met.How to test
I added a story to the example storybook called HiddenControls that lets you test the normal use-case of having "advanced" controls