Skip to content

Use region from boto3 session when possible #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

zastrowm
Copy link
Member

Description

Only use a default region if the session doesn't provide one or if the AWS_REGION environment variable is not set. Previously we were using us-west-2 even if the session could load it from the environment (either variables or profiles). No we only specify a region if the session doesn't provide one

Fixes #238

Related Issues

#238

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

I tested creating an agent:

  • With a profile region set (boto3 default behavior)
  • With an environment variable AWS_REGION specified (our custom behavior)
  • With an environment variable AWS_DEFAULT_REGION specified (boto3 default behavior)
  • Explicitly passing a region
  • Using the default (us-west-2)

All cases used the region as expected

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Only use a default region if the session doesn't provide one or if the AWS_REGION environment variable is not set.

Fixes strands-agents#238
@mehtarac mehtarac self-assigned this Jun 27, 2025
@zastrowm zastrowm enabled auto-merge (squash) June 27, 2025 17:24
@zastrowm zastrowm merged commit 94b99eb into strands-agents:main Jun 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Strands should prefer Boto3 session region instead of us-west-2
3 participants