Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async channel from Pool #1411

Conversation

Shourya742
Copy link
Contributor

@Shourya742 Shourya742 commented Jan 29, 2025

Partially closes: #1389

Notes for reviewers:

Run pool using this RUSTFLAGS="--cfg tokio_unstable" RUST_LOG=debug cargo run -- -c config-examples/pool-config-local-tp-example.toml as I have added console_subscriber for observing the task.

@Shourya742 Shourya742 force-pushed the 2025-01-29-remove-async-channel-from-pool branch 2 times, most recently from f652034 to 3b0c29f Compare January 29, 2025 07:54
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes missing coverage. Please review.

Project coverage is 19.13%. Comparing base (f7b068a) to head (2f47df7).
Report is 276 commits behind head on main.

Files with missing lines Patch % Lines
.../src/noise_connection_tokio_with_tokio_channels.rs 0.00% 118 Missing ⚠️
roles/pool/src/lib/error.rs 0.00% 4 Missing ⚠️
roles/roles-utils/network-helpers/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
- Coverage   19.34%   19.13%   -0.22%     
==========================================
  Files         144      145       +1     
  Lines       10963    11087     +124     
==========================================
  Hits         2121     2121              
- Misses       8842     8966     +124     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.57% <ø> (ø)
binary_sv2-coverage 5.36% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.38% <0.00%> (-0.04%) ⬇️
jd_server-coverage 7.79% <0.00%> (-1.23%) ⬇️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.45% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <0.00%> (ø)
mining_proxy_sv2-coverage 0.70% <0.00%> (-0.12%) ⬇️
noise_sv2-coverage 4.46% <ø> (ø)
protocols 24.81% <ø> (ø)
roles 6.19% <0.00%> (-0.24%) ⬇️
roles_logic_sv2-coverage 9.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 8.73% <0.00%> (-0.81%) ⬇️
utils 25.13% <ø> (ø)
v1-coverage 2.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shourya742 Shourya742 force-pushed the 2025-01-29-remove-async-channel-from-pool branch from 3b0c29f to aff49ea Compare January 29, 2025 13:23
@Shourya742 Shourya742 force-pushed the 2025-01-29-remove-async-channel-from-pool branch from aff49ea to 4701d37 Compare February 10, 2025 07:21
@GitGab19
Copy link
Collaborator

Should we close this for now @Shourya742 ?

@Shourya742
Copy link
Contributor Author

Should we close this for now @Shourya742 ?

yes

@Shourya742 Shourya742 closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from async-channel
2 participants