-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove async channel from Pool #1411
Remove async channel from Pool #1411
Conversation
f652034
to
3b0c29f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
- Coverage 19.34% 19.13% -0.22%
==========================================
Files 144 145 +1
Lines 10963 11087 +124
==========================================
Hits 2121 2121
- Misses 8842 8966 +124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b0c29f
to
aff49ea
Compare
…for graceful shutdown of role
…hard dependence on template provider
aff49ea
to
4701d37
Compare
Should we close this for now @Shourya742 ? |
yes |
Partially closes: #1389
Notes for reviewers:
Run pool using this
RUSTFLAGS="--cfg tokio_unstable" RUST_LOG=debug cargo run -- -c config-examples/pool-config-local-tp-example.toml
as I have added console_subscriber for observing the task.