Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sv2-ffi crate #1417

Closed
wants to merge 2 commits into from

Conversation

plebhash
Copy link
Collaborator

close #1416

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.29%. Comparing base (f54512a) to head (2ef3fda).
Report is 331 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   19.20%   18.29%   -0.91%     
==========================================
  Files         166      154      -12     
  Lines       11107    10100    -1007     
==========================================
- Hits         2133     1848     -285     
+ Misses       8974     8252     -722     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.64% <ø> (+0.08%) ⬆️
binary_sv2-coverage 5.46% <ø> (+0.12%) ⬆️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (+<0.01%) ⬆️
common_messages_sv2-coverage 0.13% <ø> (+<0.01%) ⬆️
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (+<0.01%) ⬆️
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.48% <ø> (+0.03%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.54% <ø> (+0.10%) ⬆️
pool_sv2-coverage 2.04% <ø> (ø)
protocols 22.96% <ø> (-1.79%) ⬇️
roles 3.78% <ø> (-2.76%) ⬇️
roles_logic_sv2-coverage 9.24% <ø> (+0.18%) ⬆️
sv2_ffi-coverage ?
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage ?
utils 25.13% <ø> (ø)
v1-coverage 2.46% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@plebhash plebhash force-pushed the remove-sv2-ffi-crate branch from c3aa05f to 2ef3fda Compare January 29, 2025 20:19
Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still two things to remove:

  • .github/workflows/sv2-header-check.yaml
  • step called interop-test in ci job of .github/workflows/test.yaml

@GitGab19
Copy link
Collaborator

Since we didn't find any consensus on this, maybe it's better to close this PR for now.

We can always reopen it in the future.

What do you think @plebhash?

@plebhash plebhash closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider removing sv2-ffi crate from the repo
2 participants