Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sniffer unblocking and upgrade TP #1592

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Mar 20, 2025

resolves #1591 and #1602

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.12%. Comparing base (5c63502) to head (e6f15ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   21.90%   21.12%   -0.78%     
==========================================
  Files         135      135              
  Lines        9578     9968     +390     
==========================================
+ Hits         2098     2106       +8     
- Misses       7480     7862     +382     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 10.13% <ø> (+<0.01%) ⬆️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.03% <ø> (+<0.01%) ⬆️
common_messages_sv2-coverage 0.25% <ø> (+<0.01%) ⬆️
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.54% <ø> (+<0.01%) ⬆️
jd_client-coverage 0.39% <ø> (ø)
jd_server-coverage 12.43% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 5.02% <ø> (+<0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 1.18% <ø> (ø)
noise_sv2-coverage 8.64% <ø> (+<0.01%) ⬆️
pool_sv2-coverage 5.79% <ø> (-1.21%) ⬇️
protocols 30.60% <ø> (-0.02%) ⬇️
roles 11.41% <ø> (-0.75%) ⬇️
roles_logic_sv2-coverage 15.20% <ø> (-0.03%) ⬇️
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.11% <ø> (ø)
utils 36.39% <ø> (ø)
v1-coverage 4.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Shourya742

This comment was marked as outdated.

@jbesraa jbesraa force-pushed the 2025-03-20/itf-improvements branch 3 times, most recently from d6e3035 to ee129c2 Compare March 25, 2025 16:53
@jbesraa jbesraa force-pushed the 2025-03-20/itf-improvements branch 2 times, most recently from dccc255 to c20f13f Compare March 27, 2025 13:04
@jbesraa jbesraa force-pushed the 2025-03-20/itf-improvements branch from 2e25ca1 to 7faec42 Compare March 27, 2025 13:22
@jbesraa
Copy link
Contributor Author

jbesraa commented Mar 27, 2025

This is ready for another review

@GitGab19 GitGab19 linked an issue Mar 27, 2025 that may be closed by this pull request
@jbesraa jbesraa force-pushed the 2025-03-20/itf-improvements branch 2 times, most recently from 7c8c316 to f808261 Compare March 27, 2025 15:59
@jbesraa jbesraa force-pushed the 2025-03-20/itf-improvements branch from f808261 to e6f15ac Compare March 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sleep from testing and adapt changes accordingly ITF improvements
4 participants