Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop AbortHandle from Connection::new #1595

Merged

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Mar 25, 2025

As those handles are mostly not used and they might cause ghost processes because tokio would not drop unneeded tasks if the handle is still in scope/explicitly returned.

resolves #1594

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 38.23529% with 42 lines in your changes missing coverage. Please review.

Project coverage is 21.92%. Comparing base (5c63502) to head (a93bd8b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...oles-utils/network-helpers/src/noise_connection.rs 42.37% 34 Missing ⚠️
roles/jd-client/src/lib/downstream.rs 0.00% 1 Missing ⚠️
roles/jd-client/src/lib/job_declarator/mod.rs 0.00% 1 Missing ⚠️
roles/jd-client/src/lib/template_receiver/mod.rs 0.00% 1 Missing ⚠️
roles/jd-client/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
roles/jd-server/src/lib/job_declarator/mod.rs 0.00% 1 Missing ⚠️
roles/mining-proxy/src/lib/upstream_mining.rs 0.00% 1 Missing ⚠️
roles/pool/src/lib/mining_pool/mod.rs 0.00% 1 Missing ⚠️
roles/translator/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
+ Coverage   21.90%   21.92%   +0.02%     
==========================================
  Files         135      135              
  Lines        9578     9573       -5     
==========================================
+ Hits         2098     2099       +1     
+ Misses       7480     7474       -6     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 10.12% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.03% <ø> (ø)
common_messages_sv2-coverage 0.25% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.54% <ø> (ø)
jd_client-coverage 0.39% <0.00%> (+<0.01%) ⬆️
jd_server-coverage 12.42% <0.00%> (-0.02%) ⬇️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 5.02% <ø> (ø)
mining_device-coverage 0.00% <0.00%> (ø)
mining_proxy_sv2-coverage 1.18% <0.00%> (ø)
noise_sv2-coverage 8.63% <ø> (ø)
pool_sv2-coverage 7.02% <41.93%> (+0.02%) ⬆️
protocols 30.61% <ø> (ø)
roles 12.19% <38.23%> (+0.03%) ⬆️
roles_logic_sv2-coverage 15.22% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.11% <0.00%> (ø)
utils 36.39% <ø> (ø)
v1-coverage 4.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbesraa jbesraa force-pushed the 2025-03-25/connection-without-task branch 4 times, most recently from 1e869e0 to 072bee0 Compare March 27, 2025 14:02
@jbesraa jbesraa force-pushed the 2025-03-25/connection-without-task branch from 072bee0 to 3d38df1 Compare March 27, 2025 16:01
As those handles are mostly not used and they might cause ghost
processes because tokio would not drop un-needed tasks if the handle is
still in scope/explicitly returned.
@jbesraa jbesraa force-pushed the 2025-03-25/connection-without-task branch from 3d38df1 to a93bd8b Compare March 27, 2025 16:16
@plebhash plebhash merged commit 0ee1d37 into stratum-mining:main Mar 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove abort_task from Connection::new return type
3 participants