Set GnmiControllerImpl property when loading the pipeconf #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierventre
reviewed
Feb 18, 2022
There was a problem hiding this comment.
fyi - https://gerrit.onosproject.org/c/onos/+/25319. The property is now in GnmiControllerImpl
sdn@root > cfg get org.onosproject.gnmi.ctl.GnmiControllerImpl
org.onosproject.gnmi.ctl.GnmiControllerImpl
name=readPortId, type=boolean, value=true, defaultValue=false, description=Configure read port-id for gnmi drivers; default is false.
Yi-Tseng
changed the title
Got it, will change this |
Yi-Tseng
changed the title
pierventre
approved these changes
Feb 18, 2022
Yi-Tseng
force-pushed
the
read-port-id-property
branch
from
deaf17c to
e483eda
Compare
|
retest this please |
Codecov Report
@@ Coverage Diff @@
## main #496 +/- ##
============================================
- Coverage 69.85% 69.84% -0.02%
Complexity 727 727
============================================
Files 63 63
Lines 4754 4755 +1
Branches 527 527
============================================
Hits 3321 3321
- Misses 1158 1159 +1
Partials 275 275
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
readPortIdis pipeline/pipeconf specific.We can set it when loading the fabric-tna pipeconf.