-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup README #498
Cleanup README #498
Conversation
Yi-Tseng
commented
Feb 24, 2022
- SDFAB-1047 add P4Runtime translation to document
- Update example netcfg with correct port and pipeconf
- Fix incorrect build command
- Replace Trellis doc to SD-Fabric doc
- SDFAB-1047 add P4Runtime translation to document - Update example netcfg with correct port and pipeconf - Fix incorrect build command - Replace Trellis doc to SD-Fabric doc
@@ -156,15 +156,14 @@ To build `fabric-tna.p4` using the Barefoot compiler and to create the pipeconf | |||
`.oar` package in one command: | |||
|
|||
```bash | |||
make build PROFILES=all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make build PROFILES=all
will become make clean all pipeconf
And the all
target is:
all: $(PROFILES)
Which will become
all: all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to merge when ready.
@@ -156,15 +156,14 @@ To build `fabric-tna.p4` using the Barefoot compiler and to create the pipeconf | |||
`.oar` package in one command: | |||
|
|||
```bash | |||
make build PROFILES=all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
=========================================
Coverage 69.85% 69.85%
Complexity 727 727
=========================================
Files 63 63
Lines 4763 4763
Branches 527 527
=========================================
Hits 3327 3327
Misses 1160 1160
Partials 276 276 Continue to review full report at Codecov.
|
Co-authored-by: Carmelo Cascone <[email protected]>