Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup README #498

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Cleanup README #498

merged 2 commits into from
Feb 24, 2022

Conversation

Yi-Tseng
Copy link
Collaborator

  • SDFAB-1047 add P4Runtime translation to document
  • Update example netcfg with correct port and pipeconf
  • Fix incorrect build command
  • Replace Trellis doc to SD-Fabric doc

- SDFAB-1047 add P4Runtime translation to document
- Update example netcfg with correct port and pipeconf
- Fix incorrect build command
- Replace Trellis doc to SD-Fabric doc
@@ -156,15 +156,14 @@ To build `fabric-tna.p4` using the Barefoot compiler and to create the pipeconf
`.oar` package in one command:

```bash
make build PROFILES=all
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make build PROFILES=all will become make clean all pipeconf
And the all target is:

all: $(PROFILES)

Which will become

all: all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

Copy link
Member

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge when ready.

@@ -156,15 +156,14 @@ To build `fabric-tna.p4` using the Barefoot compiler and to create the pipeconf
`.oar` package in one command:

```bash
make build PROFILES=all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #498 (b42ec4a) into main (8bbff81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #498   +/-   ##
=========================================
  Coverage     69.85%   69.85%           
  Complexity      727      727           
=========================================
  Files            63       63           
  Lines          4763     4763           
  Branches        527      527           
=========================================
  Hits           3327     3327           
  Misses         1160     1160           
  Partials        276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbff81...b42ec4a. Read the comment docs.

Co-authored-by: Carmelo Cascone <[email protected]>
@Yi-Tseng Yi-Tseng merged commit e30fb04 into main Feb 24, 2022
@Yi-Tseng Yi-Tseng deleted the readme-cleanup branch February 24, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants