[SDFAB-1100] Leverage in-order FlowRuleService APIs #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabricUpfProgrammable leverages the new APIs to guarantee in-order processing of the requests coming from the north. If batch APIs are not used there is no guarantee about the processing order in the FlowRuleService. Instead, the `striped` API allow the apps to signal a preference in the requests processing which is used by the FlowRuleService to serialize all the requests, having equal key, on the same executor. Depends on https://gerrit.onosproject.org/c/onos/+/25423
src/main/java/org/stratumproject/fabric/tna/behaviour/upf/FabricUpfProgrammable.java
Show resolved
Hide resolved
ccascone
reviewed
Mar 24, 2022
daniele-moro
approved these changes
Mar 28, 2022
charlesmcchan
approved these changes
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
============================================
- Coverage 69.96% 69.92% -0.04%
+ Complexity 740 739 -1
============================================
Files 63 63
Lines 4801 4802 +1
Branches 530 530
============================================
- Hits 3359 3358 -1
- Misses 1164 1165 +1
- Partials 278 279 +1
Continue to review full report at Codecov.
|
|
Only codecov failed. Merging anyways since the diff with the main branch is negligible (-0.04%). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FabricUpfProgrammableleverages the new APIs to guarantee in-order processing of the requests coming from the north.If batch APIs are not used there is no guarantee about the processing order in the
FlowRuleService. Instead, thestripedAPI allow the apps to signal a preference in the requests processing which is used by theFlowRuleServiceto serializeall the requests, having equal key, on the same executor.
Depends on https://gerrit.onosproject.org/c/onos/+/25423