Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDFAB-1175] Allow to modify UPF counters #517

Closed
wants to merge 9 commits into from
Closed

[SDFAB-1175] Allow to modify UPF counters #517

wants to merge 9 commits into from

Conversation

daniele-moro
Copy link
Collaborator

@daniele-moro daniele-moro commented Apr 21, 2022 •
edited
Loading

UPF counters now can be modified via the apply method of the UpfProgrammable APIs.

Related with: omec-project/up4#279

@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #517 (82d7aff) into main (a33fb69) will increase coverage by 0.31%.
The diff coverage is 70.58%.

❗ Current head 82d7aff differs from pull request most recent head 3527327. Consider uploading reports for the commit 3527327 to get more accurate results

@@             Coverage Diff              @@
##               main     #517      +/-   ##
============================================
+ Coverage     69.92%   70.24%   +0.31%     
- Complexity      739      744       +5     
============================================
  Files            63       63              
  Lines          4802     4819      +17     
  Branches        530      531       +1     
============================================
+ Hits           3358     3385      +27     
+ Misses         1165     1149      -16     
- Partials        279      285       +6
Impacted Files Coverage Δ
...abric/tna/behaviour/upf/FabricUpfProgrammable.java 65.18% <70.58%> (+3.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33fb69...3527327. Read the comment docs.

pierventre
pierventre reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main comment is related to the copyright headers. Others are minor comments.

@daniele-moro
Copy link
Collaborator Author

retest this please

pierventre
pierventre reviewed Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

@daniele-moro
Copy link
Collaborator Author

retest this please

1 similar comment
@daniele-moro
Copy link
Collaborator Author

retest this please

@daniele-moro daniele-moro mentioned this pull request May 4, 2022
Closed
@daniele-moro daniele-moro added the 🍩 merge Do not merge label May 9, 2022
@daniele-moro daniele-moro mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesmcchan charlesmcchan charlesmcchan left review comments

@pierventre pierventre pierventre approved these changes

@ccascone ccascone Awaiting requested review from ccascone

Assignees
No one assigned
Labels
🍩 merge Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniele-moro @charlesmcchan @pierventre