Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDFAB-1180] Allow to build fabric-tna when behind proxy #518

Merged
merged 1 commit into from
May 10, 2022

Conversation

daniele-moro
Copy link
Collaborator

No description provided.

@daniele-moro
Copy link
Collaborator Author

@pierventre @charlesmcchan @ccascone What do you prefer, this option or the one in UP4 (see: omec-project/up4#278)?

@pierventre
Copy link
Collaborator

no strong preference, they work both to me. My eyes tend to prefer this one though.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #518 (d190e30) into main (a33fb69) will not change coverage.
The diff coverage is n/a.

❗ Current head d190e30 differs from pull request most recent head 57d6424. Consider uploading reports for the commit 57d6424 to get more accurate results

@@            Coverage Diff            @@
##               main     #518   +/-   ##
=========================================
  Coverage     69.92%   69.92%           
+ Complexity      739      738    -1     
=========================================
  Files            63       63           
  Lines          4802     4802           
  Branches        530      530           
=========================================
  Hits           3358     3358           
  Misses         1165     1165           
  Partials        279      279           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33fb69...57d6424. Read the comment docs.

@daniele-moro daniele-moro merged commit 5376d8c into main May 10, 2022
@daniele-moro daniele-moro deleted the proxy_config branch May 10, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants