fix(useMeasure): prevent TypeError when element is not a valid DOM el… #2672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: Add element validation in useMeasure to prevent ResizeObserver crashes
Problem
The useMeasure hook can crash with TypeError: Failed to execute 'observe' on 'ResizeObserver': parameter 1 is not of type 'Element' when the element ref contains unexpected values instead of valid DOM elements.
This commonly occurs in scenarios involving:
Root Cause
The current implementation only checks for truthiness (if (!element)) but doesn't validate that the element is actually a valid DOM element before calling ResizeObserver.observe(element).
Solution
Added a type check typeof element.getBoundingClientRect !== "function" to ensure the element has the necessary DOM methods before attempting to observe it.
Benefits
Testing
Tested with Next.js dynamic imports where refs temporarily contain retry objects instead of DOM
elements.
Type of change
Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).