Skip to content

Conversation

sfc-gh-tteixeira
Copy link
Contributor

📚 Context

Add OneTrust-based cookie handling. Code by @radoslawolejniczak, I'm just creating a PR for him.

🧠 Description of Changes

Replaces the existing custom-made cookie handling code with OneTrust.

💥 Impact

Size:

  • Small
  • Not small

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-tteixeira sfc-gh-tteixeira requested a review from a team as a code owner August 29, 2025 21:14
@sfc-gh-tteixeira
Copy link
Contributor Author

For some window sizes, the banner's font is too big

Screenshot 2025-08-29 at 18 06 05

@sfc-gh-tteixeira
Copy link
Contributor Author

The "cookie policy" button doesn't do anything when I click it

Screenshot 2025-08-29 at 18 08 16

@sfc-gh-tteixeira
Copy link
Contributor Author

Is there any way to avoid hydration warnings when using OneTrust? These are very annoying when developing...

Screenshot 2025-08-29 at 18 07 33

@sfc-gh-tteixeira
Copy link
Contributor Author

Also, please make the "Cookie policy" text on the OneTrust side say the same thing as in streamlit.io. I believe it says "Cookie settings" there.

@sfc-gh-dmatthews sfc-gh-dmatthews removed the request for review from a team August 29, 2025 22:26
radoslawolejniczak added a commit to radoslawolejniczak/docs that referenced this pull request Sep 2, 2025
@radoslawolejniczak
Copy link

@sfc-gh-tteixeira I’ve updated the branch with the changes from your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants