Skip to content

Fixed price subscriptions fixes – subscription should cancel, payment intent plumbing #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed price subscriptions fixes – subscription should cancel, payment intent plumbing #1213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef07633
Subscription cancel should cancel, not delete
philip-peterson Aug 11, 2025
4935457
Payment intent plumbing fix
philip-peterson Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions fixed-price-subscriptions/server/node/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,11 @@ app.get('/invoice-preview', async (req, res) => {
app.post('/cancel-subscription', async (req, res) => {
// Cancel the subscription
try {
const deletedSubscription = await stripe.subscriptions.del(
const canceledSubscription = await stripe.subscriptions.cancel(
req.body.subscriptionId
);

res.send({ subscription: deletedSubscription });
res.send({ subscription: canceledSubscription });
} catch (error) {
return res.status(400).send({ error: { message: error.message } });
}
Expand Down Expand Up @@ -215,11 +215,14 @@ app.post(
// The subscription automatically activates after successful payment
// Set the payment method used to pay the first invoice
// as the default payment method for that subscription
const subscription_id = dataObject['subscription']
const payment_intent_id = dataObject['payment_intent']
const subscription_id = dataObject.parent.subscription_details.subscription;

const subscription = await stripe.subscriptions.retrieve(subscription_id, {
expand: ['latest_invoice.payment_intent']
});

// Retrieve the payment intent used to pay the subscription
const payment_intent = await stripe.paymentIntents.retrieve(payment_intent_id);
const payment_intent = subscription.latest_invoice.payment_intent;

try {
const subscription = await stripe.subscriptions.update(
Expand Down