Improve skills-sync automation and block manual edits#427
Conversation
…iles, generally cleared out code that only made sense when skills were manually edited in this repo
johno-stripe
requested review from
jleong-stripe,
matv-stripe,
sgr-stripe and
stevekaliski-stripe
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
![stripe-ai-sync[bot]](https://avatars.githubusercontent.com/u/856813?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR modifies files that are automatically synced from a centrally maintained copy at docs.stripe.com/.well-known/skills. Any changes made here will be overwritten by the next sync.
To make lasting changes, apply them to the source. You can find instructions at go/add-stripe-skill.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
matv-stripe
left a comment
matv-stripe
left a comment
There was a problem hiding this comment.
ty for the cleanup! quick question
| - name: Verify provider skill directories match source | ||
| run: | | ||
| out_of_sync=false | ||
|
|
||
| for provider in claude cursor; do | ||
| target="providers/$provider/plugin/skills" | ||
|
|
||
| for skill_dir in skills/*/; do | ||
| skill_name="$(basename "$skill_dir")" | ||
| diff -r "skills/$skill_name" "$target/$skill_name" > /dev/null 2>&1 || { | ||
| echo "❌ $target/$skill_name is out of sync with skills/$skill_name" |
There was a problem hiding this comment.
quick question - are we getting rid of this CI test?
There was a problem hiding this comment.
Yeah -- it seems like the test was there to pick up when a user changed something in /skills but forgot to sync it with the other provider files. Now that we've got checks in place to ensure that people never directly change files in that directory, and the same logic is being used to write the files into every one of the output directories, it seems unnecessary.
We could technically keep it, but it feels logically dead, so it felt simpler to clean out the last holdover from the previous approach! Happy to bring it back if you think otherwise, though 👍
There was a problem hiding this comment.
This PR modifies files that are automatically synced from a centrally maintained copy at docs.stripe.com/.well-known/skills. Any changes made here will be overwritten by the next sync.
To make lasting changes, apply them to the source. You can find instructions at go/add-stripe-skill.
3 participants
Summary
renamed/deleted skills on the source don't leave stale files behind.
directories, with messaging tailored for internal vs. external contributors.
edits are blocked).
providers are picked up automatically.
Test plan