-
Notifications
You must be signed in to change notification settings - Fork 793
Removed qs #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Removed qs #2116
Conversation
|
Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯 |
Seems like the only failures are prettier-related? |
may I help with the PR? |
Hi! Thanks for submitting, we'll watch the tagged issue! |
Any reason why stripe cannot just use URLSearchParams ? |
CI seems to be failing |
Is this still happening? Removing qs would be great! |
Yes, this would be amazing. qs adds an extra 18 (!) packages through transitive dependencies which is crazy for something that should be so simple |
Hi @gkiely! Checking in to see if you still plan on continuing this work |
Based off this comment
#2038 (comment)
Includes a lightweight alternative to qs.stringify that can run in worker environments.
I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)