RN Android Codegen Fixes #2148
Open
RN Android Codegen Fixes #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lng-stripe
requested changes
Sep 29, 2025
| invoke(eventName, null); | ||
| } | ||
|
|
||
| protected final void emitOnConfirmHandlerCallback(ReadableMap value) { |
Collaborator
There was a problem hiding this comment.
Could we get these changes to NativeStripeSdkModuleSpec.java merged in a separate PR to master? It'll make it easier to merge the beta branch later.
There was a problem hiding this comment.
@lng-stripe I believe that's addressed by this PR: #2151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
old-arch-codegen-androidscript to include the new Onramp module.Adds a new patch file to re-include changes to the auto-generated spec.
Runs the codegen script to verify no additional changes occur.
Motivation
This addresses an issue of the codegen being out of date, which would cause an issue in the future if run. The existing spec had not had this run since the Emitter object had be added, so there were a number of functions that still existed that were unused.
Testing
Documentation
Select one: