Skip to content

Conversation

@noahcoad
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

BTW, thank you for this checklist, it really helped me clean things up

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Task List

Packages added:
  - Task List

Processing package "Task List"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Oct 25, 2025

  • Your example keymap is not referenced anywhere. Note that you can leverage the edit_settings command to make it easy for users to find your suggested bindings and copy them over.
  • Might I suggest using an icon that doesn't have a religious connotation for "to do"? E.g. ☑️ or ⚛️ if you want one from the purple set? If it's "just" and icon the start of David feels like an odd choice.
  • As someone doesn't give a hoot about ones preferred style of indentation, the tone in that comment reads a bit off... I'd edit that out before "going public"

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Oct 25, 2025
@noahcoad
Copy link
Contributor Author

  • Your example keymap is not referenced anywhere. Note that you can leverage the edit_settings command to make it easy for users to find your suggested bindings and copy them over.

Thank you! I'll add "Key Mapping" to user settings with the key mapped there.

  • Might I suggest using an icon that doesn't have a religious connotation for "to do"? E.g. ☑️ or ⚛️ if you want one from the purple set? If it's "just" and icon the start of David feels like an odd choice.

Thanks for calling that out! YES, will update. (had used the previous bc it was the closet 'empty check box' look that stood out, but great point on it being a religious symbol)

  • As someone doesn't give a hoot about ones preferred style of indentation, the tone in that comment reads a bit off... I'd edit that out before "going public"

Oh boy, thank you, gosh I wrote that like 10 yrs ago and just now getting around to publishing. Definitely will update, thank you.

Thank you for the close review! Really appreciate the excellent feedback.

@braver
Copy link
Collaborator

braver commented Oct 29, 2025

Some of the feedback to your other packages apply here too, or the other way around... let me know when you've made an iteration and tag some new releases, and we'll do a final double-check!

@braver braver added the stale The author has not responded for at least 2 weeks label Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer stale The author has not responded for at least 2 weeks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants