Skip to content

Conversation

@braver
Copy link
Collaborator

@braver braver commented Nov 16, 2025

No description provided.

@braver braver self-assigned this Nov 16, 2025
@braver braver added the non-package This is not about new or modified packages label Nov 16, 2025
@braver
Copy link
Collaborator Author

braver commented Nov 30, 2025

@kaste

This is really good actually, using your latest version of the reviewer. I think it has all the output I'd want.

Scherm­afbeelding 2025-11-30 om 15 30 50

So, as a user of this thing I really want this :D I hope you and Fichte can work out how to manage the repo. IMO I can continue to just use your fork here. The old package test action also did not really depend on his repo anyway.

@kaste
Copy link
Contributor

kaste commented Nov 30, 2025

It becomes easier to decipher when you just have one job(?) per action(?) / file.

I may just merge into the forked main which is easier to use and to see and remember.

@michaelblyons
Copy link
Contributor

Where it says "CHECK," is it possible to (also?) include the name of the package being tested?

@kaste
Copy link
Contributor

kaste commented Dec 3, 2025

Why shouldn't that be possible, it's computers. But I also have a question:

@braver, can you just set

  permissions:
    contents: read
    pull-requests: write

in the workflow here, and I write a PR comment.

@braver
Copy link
Collaborator Author

braver commented Dec 4, 2025

Scherm­afbeelding 2025-12-04 om 18 48 09 Done

@braver braver force-pushed the braver-reviewer branch 3 times, most recently from 961274b to d9ffc1a Compare December 14, 2025 13:00
@braver
Copy link
Collaborator Author

braver commented Dec 14, 2025

📦

@braver braver merged commit 799e7f3 into master Dec 14, 2025
3 checks passed
@braver braver deleted the braver-reviewer branch December 14, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-package This is not about new or modified packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants