Skip to content

fix(isthmus): is_distinct_from tests to cover rewrite #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asuriy wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

fix(isthmus): is_distinct_from tests to cover rewrite #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion isthmus/src/test/java/io/substrait/isthmus/ComparisonFunctionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package io.substrait.isthmus;

import static org.junit.jupiter.api.Assertions.assertTrue;

import io.substrait.isthmus.sql.SubstraitCreateStatementParser;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;
Expand Down Expand Up @@ -38,13 +41,31 @@ void is_not_false() throws Exception {
void is_distinct_from(String left, String right) throws Exception {
String query = String.format("SELECT (%s IS DISTINCT FROM %s) FROM numbers", left, right);
assertSqlSubstraitRelRoundTrip(query, CREATES);

// Assert logical rewrite exists
io.substrait.plan.Plan plan =
toSubstraitPlan(
query, SubstraitCreateStatementParser.processCreateStatementsToCatalog(CREATES));
String planString = plan.toString();
assertTrue(
planString.contains("and") && planString.contains("or") && planString.contains("equal"),
"Expected Substrait plan to contain logical rewrite for IS DISTINCT FROM");
}

@ParameterizedTest
@ValueSource(strings = {"int_a", "int_b", "double_a", "double_b"})
void is_distinct_from_null_vs_col(String column) throws Exception {
String query = String.format("SELECT (NULL IS DISTINCT FROM %s) FROM numbers", column);
assertSqlSubstraitRelRoundTrip(query, CREATES);

// Assert logical rewrite exists
io.substrait.plan.Plan plan =
toSubstraitPlan(
query, SubstraitCreateStatementParser.processCreateStatementsToCatalog(CREATES));
String planString = plan.toString();
assertTrue(
planString.contains("is_not_null"),
"Expected Substrait plan to contain logical rewrite for NULL IS DISTINCT FROM to IS NOT NULL");
}

@ParameterizedTest
Expand All @@ -71,7 +92,7 @@ void least(String args) throws Exception {
})
void greatest(String args) throws Exception {
String join_args = String.join(", ", args);
String query = String.format("SELECT LEAST(%s) FROM numbers", join_args);
String query = String.format("SELECT GREATEST(%s) FROM numbers", join_args);
assertSqlSubstraitRelRoundTrip(query, CREATES);
}
}