fix: doctor command never discovers user agent plugins - #403
Conversation
registry.initialize() (which calls discoverUserPlugins()) is already called correctly in run.tsx's initializePlugins() before actually running an agent, but doctor.ts only called registerBuiltinAgents() — so `ralph-tui doctor --agent <custom-plugin>` always reported "Unknown agent plugin" even for a plugin `run` could load fine. Also adds an opt-in RALPH_TUI_DEBUG_PLUGINS env var to doctor's output, since a user plugin load failure is otherwise silently swallowed into a PluginLoadResult the CLI never prints anywhere.
|
@djbclark is attempting to deploy a commit to the plgeek Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDoctor plugin support
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The doctor.ts fix (registry.initialize() to discover user plugins) broke 9 doctor.test.ts tests whose mock registry didn't implement initialize(). Added the missing mock method, matching the real AgentRegistry interface. Confirmed zero regressions vs main across the full suite (3843 -> 3933 tests, same 71 pre-existing unrelated failures, all new grok/antigravity tests passing).
Summary
doctor's view of the world never includes user plugins.Test plan
Summary by CodeRabbit
doctorcommand now recognizes user-installed agent plugins.