Skip to content

fixed the consistency check issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed the consistency check issue #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/jagged/src/jagged_eval/sumcheck_eval.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@ pub struct JaggedSumcheckEvalProof<F> {
#[derive(Debug, Default, Clone, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
pub struct JaggedEvalSumcheckConfig<F>(PhantomData<F>);

//added a new error variant to JaggedEvalSumcheckError to handle the case where the claimedSum doesn't match
#[derive(Debug, Error)]
pub enum JaggedEvalSumcheckError<F: Field> {
#[error("sumcheck error: {0}")]
SumcheckError(SumcheckError),
#[error("claimed sum mismatch, expected: {0}, got: {1}")]
ClaimedSumMismatch(F, F),
#[error("jagged evaluation proof verification failed, expected: {0}, got: {1}")]
JaggedEvaluationFailed(F, F),
}
Expand Down Expand Up @@ -59,6 +62,14 @@ where
*partial_lagrange * *branching_program_eval
})
.sum::<EF>();
// added this missing piece to ensure that the jagged eval matches the claimed sum. as a malicious prover could
// claim a sum that is different from the actual sum, this check ensures that the sum is correct.
if jagged_eval != partial_sumcheck_proof.claimed_sum {
return Err(JaggedEvalSumcheckError::ClaimedSumMismatch(
jagged_eval,
partial_sumcheck_proof.claimed_sum,
));
}

// Verify the jagged eval proof.
let result = partially_verify_sumcheck_proof(partial_sumcheck_proof, challenger);
Expand Down
Loading