Skip to content

Conversation

@klimslim
Copy link
Contributor

@klimslim klimslim commented Dec 5, 2025

No description provided.

@klimslim klimslim force-pushed the SUS-128 branch 2 times, most recently from 74099ba to 26b44d6 Compare December 5, 2025 17:11
Copy link
Contributor

@demonfoo demonfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has an issue with tests failing on repeated runs, but @klimslim knows about that and will be addressing it. Otherwise looks reasonable and does pass all tests, as long as you know about that one thing. 👍

[SUS-128] - Add php 8.5 support to shadow
Copy link
Contributor

@demonfoo demonfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test issue is now resolved, all tests pass. LGTM.

@dzentota dzentota merged commit 72058f6 into sugarcrm:master Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants