Skip to content

💄(frontend) fine tuning emoji picker #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2025
Merged

💄(frontend) fine tuning emoji picker #1557

merged 4 commits into from
Nov 10, 2025

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Nov 4, 2025 •
edited
Loading

Purpose

Integrate the review of @rl-83 about the emoji picker feature.

Proposal

  • ✨(frontend) add "Add Emoji" button to doc options menu
  • 💄(frontend) visual improvements around the Icon

Demo

image

@AntoLC AntoLC marked this pull request as draft November 4, 2025 17:02
@AntoLC AntoLC self-assigned this Nov 4, 2025
@AntoLC AntoLC added bug Something isn't working enhancement improve an existing feature frontend labels Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Size Change: +175 B (0%)

Total Size: 3.68 MB

Filename Size Change
apps/impress/out/_next/static/4468f596/_buildManifest.js 0 B -882 B (removed) 🏆
apps/impress/out/_next/static/css/ff491ed19e7e4245.css 0 B -25.5 kB (removed) 🏆
apps/impress/out/_next/static/2c7d1cda/_buildManifest.js 883 B +883 B (new file) 🆕
apps/impress/out/_next/static/css/3a0b21465d4d66d8.css 25.5 kB +25.5 kB (new file) 🆕

compressed-size-action

@AntoLC AntoLC linked an issue Nov 4, 2025 that may be closed by this pull request
🐛 Bug Report: Sub-page titles misaligned when wrapping to two lines #1542
Closed
@AntoLC AntoLC force-pushed the enhance/fine-tuning-emoji-picker branch from e729d45 to bdf3182 Compare November 5, 2025 10:58
@AntoLC AntoLC marked this pull request as ready for review November 5, 2025 11:01
@AntoLC AntoLC changed the title Enhance/fine tuning emoji picker 💄(frontend) fine tuning emoji picker Nov 5, 2025
@AntoLC AntoLC force-pushed the enhance/fine-tuning-emoji-picker branch 2 times, most recently from c16f151 to a0a500a Compare November 5, 2025 14:27
@AntoLC AntoLC linked an issue Nov 5, 2025 that may be closed by this pull request
💄Bouton new doc to adapt #1490
Closed
@AntoLC AntoLC force-pushed the enhance/fine-tuning-emoji-picker branch 2 times, most recently from 30dbda1 to 9bd61e7 Compare November 5, 2025 14:54
@AntoLC AntoLC requested review from Ovgodd and lunika and removed request for lunika November 5, 2025 15:19
AntoLC added 3 commits November 7, 2025 09:24
@AntoLC
✨(frontend) add "Add Emoji" button to doc options menu
66f83db 
- Add "Add Emoji" button to doc options menu
- Remove default emoji when none selected
- Improve doc options styling
@AntoLC
💄(frontend) visual improvements around the Icon
a9b77fb 
With time some visual inconsistencies have crept
into the DropButton and Icon component.
This commit aims to harmonize the appearance
with the design system.
@AntoLC
🩹(frontend) set correctly query data when 401
b91840c 
When receiving a 401 error, we should set the
auth query data to null, not to an object
with user: null and authenticated: false.
This ensures that components relying on the
auth state can correctly interpret the
unauthenticated status.
@AntoLC AntoLC force-pushed the enhance/fine-tuning-emoji-picker branch from 9bd61e7 to 49cccb1 Compare November 7, 2025 09:59
@AntoLC
♻️(frontend) better handling css doc states
e5581e5 
We simplify the way we handle different doc
states (deleted / readonly) in the CSS, we avoid
props drilling and are more component focused.
@AntoLC AntoLC force-pushed the enhance/fine-tuning-emoji-picker branch from 49cccb1 to e5581e5 Compare November 7, 2025 14:31
Ovgodd
Ovgodd reviewed Nov 10, 2025
View reviewed changes
Copy link
Collaborator

@Ovgodd Ovgodd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, I just have one question: is it normal that the feature doesn’t work with SimpleDocItem?
I don’t see the Add/Delete emoji options there, and changing or removing emojis feels a bit slow on my side (around a few seconds delay).

addemoji

image

@AntoLC
Copy link
Collaborator Author

AntoLC commented Nov 10, 2025 •
edited
Loading

Everything looks good to me, I just have one question: is it normal that the feature doesn’t work with SimpleDocItem?
I don’t see the Add/Delete emoji options there, and changing or removing emojis feels a bit slow on my side (around a few seconds delay).

Yes this feature is available only for subdocuments, here the spec: https://docs.numerique.gouv.fr/docs/e94f4eb4-7a4b-4502-9865-ce057413fa92/.

For the delay, it is updated from requests (update title / select), depend your network or memory you get a latence I guess.

@AntoLC AntoLC requested a review from Ovgodd November 10, 2025 09:27
@Ovgodd
Copy link
Collaborator

Ovgodd commented Nov 10, 2025

Everything looks good to me, I just have one question: is it normal that the feature doesn’t work with SimpleDocItem?
I don’t see the Add/Delete emoji options there, and changing or removing emojis feels a bit slow on my side (around a few seconds delay).

Yes this feature a available only for subdocuments, here the spec: https://docs.numerique.gouv.fr/docs/e94f4eb4-7a4b-4502-9865-ce057413fa92/.

For the delay, it is updated from requests (update title / select), depend your network or memory you get a latence I guess.

Perfect, Thanks for all details

Ovgodd
Ovgodd approved these changes Nov 10, 2025
View reviewed changes
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gg !

@AntoLC AntoLC merged commit e5581e5 into main Nov 10, 2025
20 of 22 checks passed
@AntoLC AntoLC deleted the enhance/fine-tuning-emoji-picker branch November 10, 2025 09:47
This was referenced Nov 10, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ovgodd Ovgodd Ovgodd approved these changes

Assignees

@AntoLC AntoLC

Labels

bug Something isn't working enhancement improve an existing feature frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Sub-page titles misaligned when wrapping to two lines 💄Bouton new doc to adapt

3 participants

@AntoLC @Ovgodd