Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translated by section in credits.md #234

Merged
merged 2 commits into from
Sep 7, 2024
Merged

add translated by section in credits.md #234

merged 2 commits into from
Sep 7, 2024

Conversation

sumn2u
Copy link
Owner

@sumn2u sumn2u commented Sep 7, 2024

Added translated by section in Spanish translation.

Screenshot 2024-09-07 at 11 59 22 AM

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:35pm

@sumn2u
Copy link
Owner Author

sumn2u commented Sep 7, 2024

Hi @hamfree, can you review this PR?

@hamfree
Copy link
Contributor

hamfree commented Sep 7, 2024

Hi, Sumn2u!

I'm at a loss for words. What do I have to revise? It's your book. I'm just one of the translators. Do what you think is best.

Anyway, thank you very much!

@sumn2u
Copy link
Owner Author

sumn2u commented Sep 7, 2024

Hi, Sumn2u!

I'm at a loss for words. What do I have to revise? It's your book. I'm just one of the translators. Do what you think is best.

Anyway, thank you very much!

Could you please verify if the translation and the link I provided in this section are accurate? Once again, I truly appreciate your work in translating the book!

Screenshot 2024-09-07 at 1 16 30 PM

@hamfree
Copy link
Contributor

hamfree commented Sep 7, 2024

The link, the name and the image is ok, but the content of the alt attribute would be
"Fotografía del traductor". I'm not a girl, you know ... :-D

@sumn2u
Copy link
Owner Author

sumn2u commented Sep 7, 2024

The link, the name and the image is ok, but the content of the alt attribute would be "Fotografía del traductor". I'm not a girl, you know ... :-D

My apologies. I've updated the text accordingly. It should be good now.

@hamfree
Copy link
Contributor

hamfree commented Sep 7, 2024

All is ok now!
Thanks!

@sumn2u sumn2u merged commit 71b06c8 into main Sep 7, 2024
5 checks passed
@sumn2u sumn2u deleted the translation-credit branch September 7, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants