Merged
Conversation
99hyuk
reviewed
Aug 6, 2025
| .tax_free_amount("0") | ||
| .approval_url("http://localhost:8080/pay/success") | ||
| .cancel_url("http://localhost:8080/pay/cancel") | ||
| .fail_url("http://localhost:8080/pay/fail") |
Contributor
There was a problem hiding this comment.
현재 approval_url, cancel_url, fail_url에 localhost를 사용하고 있어 외부에서서 접근할 수 없을 것 같습니다. 저희 서버 도메인으로 바꾸셔야 할 듯 합니다.
도메인도 직접 노출보다는 환경변수 ${APP_HOST}로 처리하는 것이 좋을 것 같습니다. (prod.yml에 반영)
Contributor
There was a problem hiding this comment.
하드코딩보다 아이템명이나 가격도 등록되어 있는 객실에 맞춰 결제가 진행되는 것이 좋을 것 같습니다.
| private final ObjectMapper objectMapper; | ||
|
|
||
| @Value("${kakao.pay.secret-key}") | ||
| private String adminKey; |
Contributor
There was a problem hiding this comment.
${kakao.pay.secret-key} prod.yml에 반영 부탁드립니다! 키도 저한테 따로 보내주시면 깃허브시크릿으로 배포하겠습니다.
Contributor
There was a problem hiding this comment.
노션에 키 올려놓으신 거 확인해서 깃허브 시크릿에 등록은 해두었습니다.
다만 변수 이름을 KAKAOPAY_SECRET_KEY로 올려두어서
kakao:
pay:
secret-key: ${KAKAOPAY_SECRET_KEY}
이렇게 prod.yml에 반영 부탁드립니다!
…i' into feat/#46-kakaopay-integration-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
💬 리뷰 요청 사항
✅ 체크리스트