Skip to content

Fix the threadsafe-setenv example in the try_getenv case. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunfishcode merged 2 commits into from
Mar 6, 2025
Merged

Fix the threadsafe-setenv example in the try_getenv case. #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76a3274
Fix the threadsafe-setenv example in the `try_getenv` case.
sunfishcode Feb 15, 2025
9466296
Install libglib2.0-dev in CI for qemu.
sunfishcode Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
run: |
set -ex
sudo apt-get update
sudo apt-get install -y ${{ matrix.gcc_package }} ninja-build
sudo apt-get install -y ${{ matrix.gcc_package }} ninja-build libglib2.0-dev
upcase=$(echo ${{ matrix.host_target }} | awk '{ print toupper($0) }' | sed 's/-/_/g')
echo CARGO_TARGET_${upcase}_LINKER=${{ matrix.gcc }} >> $GITHUB_ENV
echo CC_${{ matrix.target }}=${{ matrix.gcc }} >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion example-crates/threadsafe-setenv/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ fn lookup_localhost() {
fn do_getenv() {
for _ in 0..1000 {
let r = std::env::var("doesnotexist");
assert!(r.is_ok(), "env var should not exist");
assert!(!r.is_ok(), "env var should not exist");
}
}
16 changes: 15 additions & 1 deletion tests/example_crates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,21 @@ fn example_crate_dns() {
}

#[test]
fn example_crate_threadsafe_setenv() {
fn example_crate_threadsafe_setenv_getenv() {
test_crate(
"threadsafe-setenv",
&["try_getenv"],
&[],
"will call std::env::set_var() 100 times ...\n\
spawning thread to call std::env::var (will not crash: Rust holds lock for getenv)...\n\
exiting without error\n",
"",
None,
);
}

#[test]
fn example_crate_threadsafe_setenv_lookup() {
test_crate(
"threadsafe-setenv",
&[],
Expand Down