Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request replaces the existing in-memory data storage mechanism with Redis as the primary database. This change is necessary to persist data across application restarts and improve scalability.
Configuration for Redis connection is expected to be provided via environment variables (
REDIS_URL,REDISHOST,REDISPASSWORD,REDISPORT,REDISUSER).Changes
redisdependency torequirements.txtto support Redis operations.main.pyto initialize and use a Redis client instead of in-memory lists/variables.redisandjson.get_redis_client()function to establish the connection using environment variables (specifically checking forREDIS_URL).items: List[Item] = [],current_id = 0).Notes for Reviewers
The implementation for CRUD operations (GET, POST, PUT, DELETE) using Redis is not yet complete in the provided diffs, as the focus here is solely on setting up the Redis connection infrastructure. Reviewers should confirm the environment variable handling for Redis connection is robust.