Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNFF Live Updating Longitudinal Controller #82

Draft
wants to merge 11 commits into
base: master-new
Choose a base branch
from

Conversation

Discountchubbs
Copy link

@Discountchubbs Discountchubbs commented Mar 15, 2025

Introduces a live-updating NNFF longitudinal controller for a more personalized pid controller adapted to the user's specific driving conditions.

Summary by Sourcery

Implements a live-updating NNFF longitudinal controller that adapts to the user's driving style by monitoring vehicle behavior during stopping and starting, and adjusting longitudinal control parameters accordingly.

New Features:

  • Introduces a live-updating NNFF longitudinal controller to personalize the PID controller based on driving conditions.
  • Implements a neural network to learn optimal longitudinal control parameters from braking events.
  • Adds a system to monitor and adapt longitudinal control parameters based on vehicle behavior during stopping and starting.
  • Introduces safety checks to validate parameter combinations and prevent unsafe stops.
  • Implements a system to save and load tuning parameters from persistent storage.
  • Adds tests to verify the functionality of the longitudinal live tuner and neural network.

@Discountchubbs Discountchubbs added the enhancement New feature or request label Mar 15, 2025
@Discountchubbs Discountchubbs self-assigned this Mar 15, 2025
Copy link

sourcery-ai bot commented Mar 15, 2025

Reviewer's Guide by Sourcery

This pull request introduces a live-updating NNFF longitudinal controller. It works by initializing a LongitudinalLiveTuner object in the _get_params method of each car interface. The LongitudinalLiveTuner class contains the logic for monitoring vehicle behavior, adapting longitudinal control parameters, and training a neural network to learn user driving habits. Unit tests and simulations are included to validate the implementation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduces a live-updating NNFF longitudinal controller that adapts to user-specific driving conditions.
  • Adds LongitudinalLiveTuner class to opendbc/sunnypilot/longitudinal_live_tuner.py.
  • Initializes LongitudinalLiveTuner in _get_params method of car interfaces.
  • Adds test_long_model directory with simulation and unit tests for the longitudinal live tuner.
  • Adds a neural network to learn user driving habits and adjust longitudinal control parameters accordingly.
opendbc/car/honda/interface.py
opendbc/car/tesla/interface.py
opendbc/car/ford/interface.py
opendbc/car/gm/interface.py
opendbc/car/hyundai/interface.py
opendbc/car/rivian/interface.py
opendbc/car/subaru/interface.py
opendbc/car/toyota/interface.py
opendbc/car/volkswagen/interface.py
opendbc/sunnypilot/longitudinal_live_tuner.py
opendbc/sunnypilot/test_long_model/Simulate_tuning.py
opendbc/sunnypilot/test_long_model/SimpleNeuralNetwork test.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

import time
from cereal import messaging
from collections import deque
from openpilot.common.params import Params
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to deprecate this in favor of (params) flagging to reduce dependencies on the openpilot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant