Skip to content

Conversation

@jfroche
Copy link
Collaborator

@jfroche jfroche commented Nov 11, 2025

Improvement of #1902 (reverted in #1905).

Manually create unique Postgres version names in branch often leads to version conflicts with the base branch versions. These conflicts force developers to deal with manual conflict resolution and unnecessary rebuilds.

To address this, this change implement automatic branch-based versioning for AMI builds triggered via workflow_dispatch on non-develop and non-release branches. The branch name is sanitized and appended to the Postgres version string.

We also publish pg_upgrade scripts and bin flake version right after the AMI release workflow completes.

Example: Branch 'multi-version-ext/pg-partman' produces postgres version 'multi-version-ext-pg-partman'

@jfroche jfroche requested review from a team as code owners November 11, 2025 21:08
* feat: add branch-based versioning for PR AMI builds

Manually create unique Postgres version names in branch often leads to
version conflicts with the base branch versions. These conflicts force
developers to deal with manual conflict resolution and unnecessary
rebuilds.

To address this, this change implement automatic branch-based versioning
for AMI builds triggered via workflow_dispatch on non-develop and
non-release branches. The branch name is sanitized and appended to the
Postgres version string.

Example: Branch 'multi-version-ext/pg-partman' produces postgres version
'multi-version-ext-pg-partman'

* feat: add notice message for published AMI version

Display the published postgres AMI version using GitHub Actions `::notice` annotation.

* feat: run actionlint on GitHub Actions workflows

Starting to lint GitHub Actions workflows with actionlint.

* fix: generate a unique AMI version

GitHub run_id is appended to the version suffix to ensure uniqueness.
It also enables to track the AMI back to the specific workflow run that
created it using url like: https://github.com/supabase/postgres/actions/runs/<run_id>
@jfroche jfroche force-pushed the feat/pull-request-image-version-v2 branch from be51860 to 4b0d2d2 Compare November 12, 2025 15:56
@jfroche jfroche requested a review from hunleyd November 12, 2025 16:01
…d bin flake version workflows

Once the AMI release workflow completes, it now triggers the pg_upgrade_scripts and pg_upgrade_bin flake version publishing workflows. 
This ensures that the necessary upgrade tools are published in sync with new PostgreSQL releases with the correct versioning.
@jfroche jfroche force-pushed the feat/pull-request-image-version-v2 branch from 4b0d2d2 to 6817c84 Compare November 12, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants