Skip to content

fix: typo in user facing error message #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: typo in user facing error message #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/protocols/s3/s3-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@ export class S3ProtocolHandler {
(o) => ({
Key: o.Key,
Code: 'AccessDenied',
Message: "You do not have permission to delete this object or the object doesn't exists",
Message: "You do not have permission to delete this object or the object doesn't exist",
})
)

Expand Down
10 changes: 5 additions & 5 deletions src/test/s3-protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ describe('S3 Protocol', () => {
expect(resp.Contents).toBe(undefined)
})

it('try to delete multiple objects that dont exists', async () => {
it('try to delete multiple objects that dont exist', async () => {
const bucketName = await createBucket(client)

await uploadFile(client, bucketName, 'test-1.jpg', 1)
Expand Down Expand Up @@ -1039,13 +1039,13 @@ describe('S3 Protocol', () => {
Key: 'test-2.jpg',
Code: 'AccessDenied',
Message:
"You do not have permission to delete this object or the object doesn't exists",
"You do not have permission to delete this object or the object doesn't exist",
},
{
Key: 'test-3.jpg',
Code: 'AccessDenied',
Message:
"You do not have permission to delete this object or the object doesn't exists",
"You do not have permission to delete this object or the object doesn't exist",
},
])

Expand Down Expand Up @@ -1142,14 +1142,14 @@ describe('S3 Protocol', () => {
expect(headObj.CacheControl).toBe('max-age=2009')
})

it('will not be able to copy an object that doesnt exists', async () => {
it('will not be able to copy an object that doesnt exist', async () => {
const bucketName1 = await createBucket(client)
await uploadFile(client, bucketName1, 'test-copy-1.jpg', 1)

const copyObjectCommand = new CopyObjectCommand({
Bucket: bucketName1,
Key: 'test-copied-2.jpg',
CopySource: `${bucketName1}/test-dont-exists.jpg`,
CopySource: `${bucketName1}/test-doesnt-exist.jpg`,
})

try {
Expand Down