Skip to content

Conversation

Mike9330
Copy link

@Mike9330 Mike9330 commented Sep 1, 2025

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • Good understanding of binary search and its applications.
    • Code is clean and follows good practices.
    • Correctly identifies edge cases and handles them well.
  • Areas for Improvement:

    • For searchMatrix.java, consider treating the 2D matrix as a 1D array to achieve O(log mn) time complexity. This would involve converting the 1D index to 2D indices.
    • Add more descriptive comments to explain the logic, especially for the infiniteArray.java solution.
    • Ensure that the time and space complexity annotations are accurate. For example, searchMatrix.java's time complexity is O(m log n), not O(n).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants