Skip to content

Conversation

imran514
Copy link

@imran514 imran514 commented Oct 1, 2025

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student demonstrates a good understanding of hash maps and queues.
  • The double hashing approach in MyHashMap is conceptually sound.
  • The MyQueue implementation is efficient and correctly uses two stacks.

Areas for Improvement:

  • The 3D array structure in MyHashMap is unconventional and could be simplified to use a more standard approach like separate chaining with linked lists.
  • The special case for hash1(key) == 0 should be removed as it doesn't provide any benefit and complicates the code.
  • More comments explaining the design choices would improve readability.
  • The MyQueue implementation, while correct, was not part of the original problem and should be separated if this is meant to be a focused submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants