Skip to content

Conversation

Shalinid8
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Problem-1 (MyQueue): The solution is well-implemented and matches the reference solution. The comments and structure are good. No improvements needed here.
  • Problem-2 (MyHashSet): The solution is mostly correct but has a minor issue in the initialization of the secondary bucket. The secondary bucket should be initialized only when needed, but the current implementation initializes it for all primary indices, which could lead to unnecessary memory usage. Also, the remove method returns False when the primary bucket is not initialized, which is inconsistent with the expected behavior (it should do nothing and return None). The contains method should also handle the case where the primary bucket is not initialized more gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants