Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1373 +/- ##
==========================================
+ Coverage 88.23% 97.84% +9.60%
==========================================
Files 86 38 -48
Lines 4311 2092 -2219
Branches 180 0 -180
==========================================
- Hits 3804 2047 -1757
+ Misses 463 45 -418
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d10r
commented
Apr 25, 2023
hellwolf
reviewed
Apr 26, 2023
hellwolf
reviewed
Apr 26, 2023
hellwolf
reviewed
Apr 26, 2023
hellwolf
approved these changes
Apr 26, 2023
Contributor
hellwolf
left a comment
There was a problem hiding this comment.
Thank you for nixifying workflows!
XKCD Comic RelifLink: https://xkcd.com/1373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is about making workflows less flaky, mainly by avoiding the implicit fetching of additional binaries at runtime (after dependencies were installed):
tasks/shellcheck-all-tasks.shnow checks if the binary exists in PATH (provided by Nix shell) and only prints a warning if not.CONTRIBUTING.md- TODO: update the section Releases (seems outdated, not related to this PR though)