Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the digest of an image on fly m create #4195

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

kzys
Copy link
Member

@kzys kzys commented Jan 29, 2025

Change Summary

This change fixes fly pg create too.

What and Why:

How:

Related to:


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@kzys kzys force-pushed the keep-digest branch 2 times, most recently from c1d2fc8 to 568c347 Compare January 30, 2025 00:17
@kzys kzys marked this pull request as ready for review January 30, 2025 01:15
@kzys kzys requested a review from davissp14 January 30, 2025 18:45
@davissp14
Copy link
Contributor

davissp14 commented Jan 30, 2025

This shouldn't actually impact fly pg create, but good stuff none the less!

PG has it's own special logic:

flyctl/flypg/launcher.go

Lines 100 to 112 in 74f80ea

if config.ImageRef == "" {
imageRepo := "flyio/postgres"
if config.Manager == ReplicationManager {
imageRepo = "flyio/postgres-flex"
}
imageRef, err := client.GetLatestImageTag(ctx, imageRepo, config.SnapshotID)
if err != nil {
return err
}
config.ImageRef = imageRef
}

@kzys
Copy link
Member Author

kzys commented Feb 7, 2025

This shouldn't actually impact fly pg create, but good stuff none the less!

Right. Let me fix the commit message...

@kzys kzys merged commit 225918d into master Feb 8, 2025
30 checks passed
@kzys kzys deleted the keep-digest branch February 8, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants