token refresh improvements #4281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btoews
approved these changes
Mar 31, 2025
Comment on lines
+193
to
+196
| updated, err := t.Update(ctx, updateOpts...) | ||
| if err == nil || !strings.Contains(err.Error(), "missing user-url callback") { | ||
| return updated, err | ||
| } |
There was a problem hiding this comment.
A comment explaining that we can only parallelize if WithUserURLCallback is omitted might be useful. Without that knowledge it's confusing why we'd do it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to improve token-refresh behavior in the client:
Tokens.updatewithout theUserURLCallbackoption (which can now fetch tokens in parallel), and then retry with the UserURLCallback option only if the first attempt returned any errors.advancePruneduration (from the default 1 minute) so the foreground thread has an advance-prune duration of 30 seconds while the background thread has 2 minutes. This should make it more likely for tokens to be refreshed in the background rather than delay foreground operations.