Support JSON output of machine VM sizes #4297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes superfly#4146 Regressed in bd6d966 according to bisect. Previously the JSON output format included priceMonth and priceSecond as it was a dump of [fly.VMSize](https://pkg.go.dev/github.com/superfly/fly-go#VMSize) returned from the API, but the function which returned this information has been removed in a different change. Since the non-JSON format doesn't include this information, that's probably a future enhancement to add it to both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in bd6d966 according to bisect.
Previously the JSON output format included
priceMonthandpriceSecondas it was a dump of fly.VMSize returned from the API, but the function which returned this information (client.PlatformVMSizes) has also been removed in a different change. Since the non-JSON format doesn't include this information, that's probably a future enhancement to add it to both tabular output and JSON output, and apparently the exact format of the JSON is not important per the linked issue as it is not documented.