Skip to content

Don't pick 'first' machine if specified machine is not found #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Don't pick 'first' machine if specified machine is not found #4300

merged 1 commit into from
May 4, 2025

Conversation

grgar
Copy link
Contributor

@grgar grgar commented Apr 8, 2025 •
edited
Loading

Also fix nearby error handling where wrong err is used in condition. Fixed in #4325.

@grgar
Copy link
Contributor Author

grgar commented May 4, 2025

@rubys caught the wrong err issue in #4325 so I'll remove that from this PR. #4325 does add a message to inform that the first available machine is being picked, but I still think it's a surprise to pick a machine different than the one a user has specifically selected.

@rubys rubys self-assigned this May 4, 2025
@rubys rubys merged commit a5404d7 into superfly:master May 4, 2025
6 checks passed
@grgar grgar deleted the dev/machine branch May 4, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rubys rubys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fly ssh console opens a session into wrong machine if the requested machine is stopped
2 participants
@grgar @rubys