feat: saml support #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Sep 15, 2025
api_spec.yaml
Outdated
| '500': | ||
| $ref: '#/components/responses/500' | ||
|
|
||
| /appid-<appId>/<tenantId>/recipe/saml/clients/create: |
There was a problem hiding this comment.
If we are using PUT then we should have it as saml/clients, if we are doing create then it should be POST (and/or rename it to POST createOrUpdate)
Suggested change
| /appid-<appId>/<tenantId>/recipe/saml/clients/create: | |
| /appid-<appId>/<tenantId>/recipe/saml/clients: |
api_spec.yaml
Outdated
Comment on lines
8407
to
8410
| accessToken: | ||
| type: string | ||
| idToken: | ||
| type: string |
There was a problem hiding this comment.
This is a bit confusing. I'm guessing this is to reuse as much as possible from the node third-party recipe, but I'd much rather have these as "special providers" on the node level and do it in a single core call (which I think would be the callback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs for SAML support