Skip to content

Conversation

@deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented Nov 20, 2025

Summary of change

Fixes #975. This PR fixes an inconsistency with the custom framework where the sendJSONResponse was not following the behaviour where subsequent calls to the function would be ignored (so that overrides can utilise it to send a response back).

Related issues

Test Plan

All custom framework tests should pass

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2025

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5779c31
Status: ✅  Deploy successful!
Preview URL: https://3229e80b.supertokens-node-b95.pages.dev

View logs

@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review November 20, 2025 02:47
@porcellus porcellus merged commit c57b9dd into 23.1 Nov 25, 2025
22 of 23 checks passed
@porcellus porcellus deleted the fix/send-json-response-not-being-ignored branch November 25, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants