Skip to content

Comments

Sync with upstream v2.2.6 + enhanced features#7

Merged
devth merged 25 commits intomainfrom
sync-with-upstream-clean
Sep 8, 2025
Merged

Sync with upstream v2.2.6 + enhanced features#7
devth merged 25 commits intomainfrom
sync-with-upstream-clean

Conversation

@saada
Copy link

@saada saada commented Aug 14, 2025

Summary

This PR syncs our fork with the latest upstream LaunchDarkly release (v2.2.6) and includes our enhanced features:

Upstream Changes (v2.2.6)

  • Updated to Ruby 3.1+ minimum requirement
  • Added logger as explicit dependency
  • Fixed string encoding issues
  • Various bug fixes and improvements

Our Enhanced Features

  • POST/PUT request support: HTTP methods beyond GET with JSON payload support
  • Proxy authentication fix: Correct parameter names (proxy_username/proxy_password)
  • Optional parsing mode: Bypass SSE parsing for raw data streaming
  • SSL verification override: Optional disable for development/testing (secure by default)

Compatibility

All changes maintain backward compatibility. Existing code continues to work unchanged since all new parameters have sensible defaults.

Test Status

  • All tests pass
  • Backward compatibility maintained
  • Based on latest upstream v2.2.6

matt-dutchie and others added 25 commits March 10, 2023 11:11
…unchdarkly#36)

In some environments, retrieving the `content-type` header directly from the
headers hash was returning an empty string. In those environments, the header
was stored as `Content-Type`. By updating the code to use the provided
`content_type` method provided on the response object, we can shield ourselves
from casing issues like this in the future.
🤖 I have created a release *beep* *boop*
---


##
[2.2.3](launchdarkly/ruby-eventsource@2.2.2...2.2.3)
(2025-03-07)


### Bug Fixes

* Provide thread name for inspection
([launchdarkly#46](launchdarkly#46))
([191fd68](launchdarkly@191fd68))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop*
---


##
[2.2.4](launchdarkly/ruby-eventsource@2.2.3...2.2.4)
(2025-04-18)


### Bug Fixes

* Remove rake dependency from gemspec
([launchdarkly#53](launchdarkly#53))
([8be0ccc](launchdarkly@8be0ccc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
In a future version of Ruby, literal strings will be frozen by default.
To avoid this causing an issue (and raising deprecation warnings now),
we are explicitly marking this literal string as unfrozen.
🤖 I have created a release *beep* *boop*
---


##
[2.2.5](launchdarkly/ruby-eventsource@2.2.4...2.2.5)
(2025-07-14)


### Bug Fixes

* Bump minimum to ruby 3.1
([launchdarkly#57](launchdarkly#57))
([93a9947](launchdarkly@93a9947))
* Explicitly mark buffer variable as unfrozen
([launchdarkly#59](launchdarkly#59))
([ccf79af](launchdarkly@ccf79af))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…kly#60)

Similar to the work done in ccf79af, we are updating this library to
handle the upcoming change where strings are frozen by default.
Starting in 3.5.0, `logger` will no longer be a part of the default
gems. v1.5 of the logger was shipped with Ruby 3.1.0, so this should
maintain equivalent functionality.
🤖 I have created a release *beep* *boop*
---


##
[2.2.6](launchdarkly/ruby-eventsource@2.2.5...2.2.6)
(2025-07-15)


### Bug Fixes

* Add `logger` as explicit dependency
([launchdarkly#61](launchdarkly#61))
([50efb0d](launchdarkly@50efb0d))
* Update `force_encoding` to operate on unfrozen string
([launchdarkly#60](launchdarkly#60))
([0e2e80d](launchdarkly@0e2e80d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Add support for POST/PUT HTTP methods with JSON payload
- Fix proxy authentication parameter names (proxy_username/proxy_password)
- Add optional parsing mode to bypass SSE parsing for raw data streaming

These changes enable more flexible usage patterns while maintaining
backward compatibility with existing GET-only SSE implementations.
Add verify_ssl parameter (defaults to true) to allow disabling SSL
certificate verification for development, testing, and internal networks.
This maintains security by default while providing flexibility when needed.
Remove extra empty line at class body beginning in BasicEventParser.
@saada saada requested review from devth and jefferson-surge August 14, 2025 17:42
@devth devth merged commit 7fe54dd into main Sep 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants