Improve and refactor derive logic. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelSkayn
force-pushed
the
refactor-derive-logic
branch
from
d29b888 to
8cdb4b3
Compare
emmanuel-keller
approved these changes
Aug 23, 2024
rushmorem
approved these changes
Aug 23, 2024
kearfy
approved these changes
Aug 23, 2024
tobiemh
approved these changes
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the derive macro to better support removing fields in a enum variant and removing the fields of types which are no longer used in the latest revision.
This PR introduces field structs for enum variants.
When a field is removed from an enum variant, the convert function now looks like
fn(&mut FieldStruct,revision: u16, value: T) -> Result<()>whereFieldStructis a generated struct which has the same fields as the variant has at the current revision.Furthermore when a variant is removed the convert function now takes this field struct as an argument.
This PR also introduces an option to override the default generated discriminant values for enum variants. This is useful for compatibility with previous versions of revision which had different behavior.