test: lock in faithful printing of optional identifiers#143
Closed
baseballyama wants to merge 1 commit into
Closed
test: lock in faithful printing of optional identifiers#143baseballyama wants to merge 1 commit into
baseballyama wants to merge 1 commit into
Conversation
Add regression tests ensuring esrap preserves the `?` on optional identifiers (introduced in sveltejs#139), covering optional parameters with and without a type annotation. Documents that sveltejs#142 was a Svelte-side issue (stale TS-only `optional` flag after stripping types), fixed in Svelte 5.56.4, not an esrap bug.
|
Member
Author
|
I found a similar test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #142
Add regression tests ensuring esrap preserves the
?on optional identifiers (introduced in #139), covering optional parameters with and without a type annotation. Documents that #142 was a Svelte-side issue (stale TS-onlyoptionalflag after stripping types), fixed in Svelte 5.56.4, not an esrap bug.Since
function a(disabled?)is valid in TypeScript, I believe the current behavior of esrap is correct.https://www.typescriptlang.org/play/?noImplicitAny=false#code/GYVwdgxgLglg9mABAQwBQBMYGdkCMA2ApugPwCUiA3gFCJ2IQJZxEB0+cA5htnkemWoBfIA