Skip to content

Conversation

@floriskn
Copy link

Fix async params reset in Pyramid component

Closes sveltejs/svelte#17079


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: 7669fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sillvva
Copy link
Contributor

sillvva commented Oct 30, 2025

It's definitely better, but I'm still noticing an issue here with this PR installed:

https://stackblitz.com/edit/sveltejs-kit-template-default-ndhoiwgy?file=package.json,src%2Froutes%2F[slug]%2F%2Bpage.svelte

@floriskn
Copy link
Author

Yes, I noticed that too. Even without a top-level await, there’s still a weird bug: if you have two links to the same slug, hover over both, and then click one, the page params ends up empty.

@floriskn
Copy link
Author

floriskn commented Oct 30, 2025

I also noticed that if you don’t have a +layout, the page doesn’t render at all after hovering both links and then clicking one. Example here: https://stackblitz.com/edit/sveltejs-kit-template-default-4l8r8anj?file=src%2Froutes%2F%5Bslug%5D%2F%2Bpage.svelte

@floriskn floriskn closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

params becomes empty object ({}) after any async work

2 participants