fix: set compilerOptions.css to 'injected' when emitCss is false#232
Closed
zeroberry wants to merge 1 commit into
Closed
fix: set compilerOptions.css to 'injected' when emitCss is false#232zeroberry wants to merge 1 commit into
zeroberry wants to merge 1 commit into
Conversation
Member
|
Thank you! And sorry for not looking into this - I think #236 is a slightly better solution, so I'm gonna close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the default value for
compilerOptions.csshas been changed to'external'in Svelte 5, using onlyemitCss: falseresults in<style>tag not being included anywhere in the output.Since the intention of
emitCss: falseis to inject CSS into JavaScript, I think it's better to setcompilerOptions.cssto'injected'whenemitCss: false.