Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): make URL search params parsing and serialization WHATWG URL compliant #9809

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #9804

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky, as it looks like it's solving some problem, but it just tries to compensate for deficiencies of in operator. More info in 12a9fbc.

      if (!Object.prototype.hasOwnProperty.call(params, i)) {
        continue
      }

@char0n char0n changed the title fix(utils): make search parsing and serializing WHATWG compliant fix(utils): make URL search params parsing and serialization WHATWG URL compliant Apr 11, 2024
@char0n char0n merged commit 52c4b95 into master Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants