Skip to content

Conversation

@bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Aug 4, 2025

No description provided.

@bvanjoi bvanjoi requested review from a team as code owners August 4, 2025 06:28
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: d69aaaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Austaras
Copy link
Member

Austaras commented Aug 4, 2025

Intersting. But why?

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Performance Report

Merging #10973 will not alter performance

Comparing bvanjoi:main (d69aaaa) with main (c8a2668)

Summary

✅ 140 untouched benchmarks

@kdy1 kdy1 changed the title feat(ecma_ast): node id for ident feat(es/ast): Add node id to Ident Aug 4, 2025
@kdy1 kdy1 changed the base branch from main to dev/rust August 4, 2025 13:35
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is for reimplementing variable management, right?

@kdy1
Copy link
Member

kdy1 commented Aug 4, 2025

I used dev/rust because this is a Wasm-breaking change

@kdy1 kdy1 merged commit 39f5318 into swc-project:dev/rust Aug 4, 2025
173 checks passed
@kdy1 kdy1 added this to the Planned milestone Aug 4, 2025
@mischnic
Copy link
Contributor

mischnic commented Aug 5, 2025

What’s the usecase here?
And why only identifier and not every node type?
In particular: what benefit does the nodeid have over the atom, context tuple which is also unique for the variable?

bvanjoi added a commit to bvanjoi/swc that referenced this pull request Aug 11, 2025
bvanjoi added a commit to bvanjoi/swc that referenced this pull request Aug 11, 2025
@kdy1
Copy link
Member

kdy1 commented Aug 12, 2025

@mischnic Maybe #10998 (review)?

I assumed that he's going to use sequential node IDs to reimplement variable management, but it seems like he is trying to have a faster version of Id.

@kdy1 kdy1 modified the milestones: Planned, 1.13.4 Aug 21, 2025
kdy1 pushed a commit that referenced this pull request Sep 6, 2025
bvanjoi added a commit to bvanjoi/swc that referenced this pull request Sep 9, 2025
bvanjoi added a commit to bvanjoi/swc that referenced this pull request Sep 9, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants