forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 341
🍒 [lldb] Add build option to specify the libxml 2 version (llvm#142183) #10774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Steelskin
wants to merge
1
commit into
swiftlang:stable/20240723
Choose a base branch
from
Steelskin:fabrice/cp-option-lldb-libxml2-version
base: stable/20240723
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🍒 [lldb] Add build option to specify the libxml 2 version (llvm#142183) #10774
Steelskin
wants to merge
1
commit into
swiftlang:stable/20240723
from
Steelskin:fabrice/cp-option-lldb-libxml2-version
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
approved these changes
May 30, 2025
@swift-ci test |
|
@swift-ci please test Windows platform |
The Swift Windows toolchain uses its own static build of libxml 2, which is more recent than 2.8, resulting in the provided libxml 2 to be rejected. This change allows to specify a custom version for libxml 2, while defaulting to 2.8. (cherry-picked from commit llvm/llvm-project@a080c74)
00f7208
to
0dbbcb7
Compare
@swift-ci please test |
Please test with following PRs: @swift-ci please test Windows platform |
The |
@swift-ci please test macOS platform |
@swift-ci please test Windows platform |
1 similar comment
@swift-ci please test Windows platform |
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift Windows toolchain uses its own static build of libxml 2, which is more recent than 2.8, resulting in the provided libxml 2 to be rejected. This change allows to specify a custom version for libxml 2, while defaulting to 2.8.
(cherry-picked from commit llvm/llvm-project@a080c74)